-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72441/#review220661
-----------------------------------------------------------



can you add a small readme or doc on steps to start atlas with standalone solr 
(http) and attach it to JIRA.


graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 40 (patched)
<https://reviews.apache.org/r/72441/#comment309227>

    nit: unused imports in line 40 and 41. consider removing it


- Sarath Subramanian


On April 29, 2020, 3:32 a.m., Damian Warszawski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72441/
> -----------------------------------------------------------
> 
> (Updated April 29, 2020, 3:32 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas does not support running Solr in standalone(http) mode.
> 
> It is especially useful for testing purposes to make setup as simple as 
> possible without Zookeeper. It also enables full integration with JanusGraph 
> as it support both mode of running Solr `cloud` and `http` 
> https://docs.janusgraph.org/index-backend/solr/. Additional benefit is to 
> decouple hbase and solr while running embedded mode so that solr can be run 
> in embbeded mode with external hbase.
> 
> Proposed solution
> 
> call solr V1 API  while creating/updating request handlers in standalone solr
> update atlas start script to enable standalone embedded solr
> 
> Reference to jira https://issues.apache.org/jira/browse/ATLAS-3654
> Patch was applied against master branch
> 
> 
> Diffs
> -----
> 
>   distro/src/bin/atlas_config.py f09026ff9 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
>  ba65f3d00 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 484c161f0 
> 
> 
> Diff: https://reviews.apache.org/r/72441/diff/1/
> 
> 
> Testing
> -------
> 
> Patch was applied and verified on our dev env with embedded solr and external 
> hbase.
> 
> 
> Thanks,
> 
> Damian Warszawski
> 
>

Reply via email to