-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72533/
-----------------------------------------------------------
(Updated May 21, 2020, 3:42 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
Bugs: ATLAS-3802
https://issues.apache.org/jira/browse/ATLAS-3802
Repository: atlas
Description
-------
Issue: When filter with 'attribute' != 'value' is searched, it doesn't fetch
entities where attribute is not present.
Workaround: In the current implementation attribute = null is ignored, So now
we can allow null when Operator is NEQ.
Diffs
-----
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
4408cd449
repository/src/test/java/org/apache/atlas/BasicTestSetup.java 7508f7855
repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java
95f782abb
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
1951c3937
Diff: https://reviews.apache.org/r/72533/diff/1/
Testing
-------
Added test cases and manually tested NEQ operator for below scenarios:
1) Non String Attribute -> index query
2) String Attributes -> graph query
3) pipeSeperated Attributes (classificationNames,labels) -> NOT_CONTAINS
operator -> graph query
4) businessMetadata attribute
Thanks,
Pinal Shah
