----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72569/#review220957 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java Lines 72 (patched) <https://reviews.apache.org/r/72569/#comment309691> Since indexSearchPrefix is not updated after initialization in constructor, consider marking this as final. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java Lines 68 (patched) <https://reviews.apache.org/r/72569/#comment309690> Consider initializing with INDEX_SEARCH_VERTEX_PREFIX_DEFAULT. private static String INDEX_SEARCH_PREFIX = INDEX_SEARCH_VERTEX_PREFIX_DEFAULT; - Madhan Neethiraj On June 5, 2020, 7:51 a.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72569/ > ----------------------------------------------------------- > > (Updated June 5, 2020, 7:51 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon > Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3816 > https://issues.apache.org/jira/browse/ATLAS-3816 > > > Repository: atlas > > > Description > ------- > > Direct index query on janusgraph throws > java.lang.IllegalArgumentException: Found reference to non-existant property > key in query at position... > > Please refer jira for more details. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 4fa6dadfb > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java > 2408287bf > > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java > 622c90019 > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > 5de4db560 > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 5ffd88b85 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > fab707455 > > repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java > e5e527fdf > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java > bf46c4722 > > repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java > 1f077ba06 > > > Diff: https://reviews.apache.org/r/72569/diff/1/ > > > Testing > ------- > > Manual testing for identified senarios. > > PC build : > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1955/console > (Finished: SUCCESS) > > > Thanks, > > Nikhil Bonte > >
