----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72576/#review220975 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 8, 2020, 10:48 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72576/ > ----------------------------------------------------------- > > (Updated June 8, 2020, 10:48 p.m.) > > > Review request for atlas, Ashutosh Mestry, chaitali, Jayendra Parab, Madhan > Neethiraj, Mandar Ambawane, mayank, mayank jain, Nixon Rodrigues, Pinal Shah, > and Sidharth Mishra. > > > Bugs: ATLAS-3826 > https://issues.apache.org/jira/browse/ATLAS-3826 > > > Repository: atlas > > > Description > ------- > > Basic search not using index query for string tokenized attributes. > > The following string tokenized attributes: > > Asset.__s_name > Asset.__s_owner > Asset.__s_displayName > Asset.__s_userDescription > _s__createdBy > _s__modifiedBy > > > uses graph query and this might be expensive when there are large number of > entities in the graph. String tokenized attributes should use index query for > faster performance. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 3962c3c42 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 4b0027ea5 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 2c5f925c7 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > d53690081 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > fc5d48d22 > > > Diff: https://reviews.apache.org/r/72576/diff/2/ > > > Testing > ------- > > manually validated, string tokenized attributes uses index query. > > Precommit - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1957/console > > > Thanks, > > Sarath Subramanian > >
