-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72567/
-----------------------------------------------------------

(Updated June 25, 2020, 9:17 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
-------

commented one testcase, need to look, succesful on local but failed for 
precommit


Bugs: ATLAS-3782
    https://issues.apache.org/jira/browse/ATLAS-3782


Repository: atlas


Description
-------

The operator 'SearchParameters.Operator.NOT_CONTAINS' is defined and 
implemented in SearchProcessors. It would allow a search of entities that do 
not contain in given string in a specified attribute (eg exclude entities from 
search that contain 'temp' in the qualified name). 

JanusGraph doesn't allow NOT_CONTAINS operator. So we will handle this in 
inmemory
BasicSearch can generates query via three modes
1. Index query -> NOT_CONTAINS will not be supported
2. InMemeory Predicated -> NOT_CONTAINS will be supported, Already handled #123 
SearchProcessor
3. Graph query -> NOT_CONTAINS will not be supported

We need to apply filter(inMemoryPredicate) after either index/graph query.

To support above, i have modified ClassificationSearchProcessor
+ For both cases index as well as graph, added typeNamePredicate and 
attributePredicate
+ Added these predicate after query
- Removed gremlinQuery block


Diffs (updated)
-----

  
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
 5dd0d7f97 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
ad48be11b 
  repository/src/test/java/org/apache/atlas/BasicTestSetup.java 8b98b3990 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java
 9b16e919d 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 43f11d1df 


Diff: https://reviews.apache.org/r/72567/diff/3/

Changes: https://reviews.apache.org/r/72567/diff/2-3/


Testing
-------

Added testcases
Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952


Thanks,

Pinal Shah

Reply via email to