-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72625/#review221085
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 607 (patched)
<https://reviews.apache.org/r/72625/#comment309892>

    Do we really need to compare edge end points?
    
    can we do:
    
    once you get relationshipEdge, you can get the typeName of the other vertex 
(not entityVertex - comparing vertexId). 
    
    From this typeName - for e.g. 'hive_storagedesc' you can get entityType
    
    relationshipEndEntityType = 
typeRegistry.getEntityTypeByName(otherEntityTypeName);


- Sarath Subramanian


On June 28, 2020, 10:06 p.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72625/
> -----------------------------------------------------------
> 
> (Updated June 28, 2020, 10:06 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3866
>     https://issues.apache.org/jira/browse/ATLAS-3866
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Issue:** In relationship api v2/relationship, for hive_storagedesc it 
> throws exception
> 
> **Reason:** it is because, sort attribute is assigned 'name' as default, and 
> 'name' attribute is not in the defination of hive_storagedesc.
> 
> **Workaround:** Validate if attribute is present in relationship end def, if 
> not ignore sorting
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  dd4d1b441 
> 
> 
> Diff: https://reviews.apache.org/r/72625/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested
> Precommit :
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Reply via email to