----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72648/#review221143 -----------------------------------------------------------
distro/src/conf/atlas-application.properties Lines 285 (patched) <https://reviews.apache.org/r/72648/#comment309933> 1. The name of this property shouldn't be "exclude", because we aren't excluding, just that we aren't overriding Spring's default headers 2. Instead of having list of headers that we won't override Spring's default behaviour, we should have the list of headers whom we are going to customize, like CONTENT_SEC_POLICY_VAL. This list will be smaller than what we will specify here. webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java Lines 79 (patched) <https://reviews.apache.org/r/72648/#comment309934> 1. Instead of casting again and again, we should put it in a variable and use that variable 2. Instead of passing null, consider passing empty array. - Jayendra Parab On July 7, 2020, 9:30 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72648/ > ----------------------------------------------------------- > > (Updated July 7, 2020, 9:30 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3841 > https://issues.apache.org/jira/browse/ATLAS-3841 > > > Repository: atlas > > > Description > ------- > > Currently headers setting code is scattered at different places. > In this patch, code refactoring is done to set response headers from > AtlasHeaderFilter.java > > This patch provides flexibility to select response headers to be excluded. > Also this patch provides flexibility to select file formats to be excluded > from applying response headers. > > > Diffs > ----- > > distro/src/conf/atlas-application.properties e06e74a > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > d9b1c82 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java > df3fce6 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java > c629a7e > webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java > fa7218c > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java > 1944a9f > webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java > a117df6 > > webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java > e7a5d66 > webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java > e74a9e9 > webapp/src/main/webapp/WEB-INF/web.xml 2595a15 > > > Diff: https://reviews.apache.org/r/72648/diff/1/ > > > Testing > ------- > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2015/console > > > Thanks, > > Mandar Ambawane > >
