----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72652/#review221144 -----------------------------------------------------------
common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java Line 88 (original), 86 (patched) <https://reviews.apache.org/r/72652/#comment309936> The "/" at the end doesn't look correct - given the original URL doesn't end with "/". Please review and update lines #86, #89, #93, #101, #104, #108. Thinking further, if there is no way to determine/differentiate whether a key is a directory or a file, I suggest to remove the trialing "/" from qualifiedName for all keys - even if its present in the original URL. - Madhan Neethiraj On July 7, 2020, 3:29 p.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72652/ > ----------------------------------------------------------- > > (Updated July 7, 2020, 3:29 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon > Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3879 > https://issues.apache.org/jira/browse/ATLAS-3879 > > > Repository: atlas > > > Description > ------- > > The support for Apache Ozone was added in ATLAS-3836. Currently, ozone_key > entity is getting created under ozone_bucket, but there is no support to > create a hierarchy of parent ozone_key and child ozone_key. > > e.g. > > -> CREATE EXTERNAL TABLE sales (id int) row format delimited fields > terminated by ' ' stored as textfile location > 'o3fs://bucket1.volume1.ozone1/sale1/q1/sales'; > > This query will create only 1 ozone_key directly under bucket "bucket1". > > Created entities : > > o3fs://volume1@cm (ozone_key) > o3fs://volume1.bucket1@cm (ozone_bucket) > o3fs://bucket1.volume1.ozone1/sale1/q1/sales@cm (ozone_key) > > > > This Jira will improve implementation to support creating the hierarchy of > ozone_keys. > > With this, above query will result into following entites > > o3fs://volume1@cm (ozone_key) > o3fs://volume1.bucket1@cm (ozone_bucket) > o3fs://bucket1.volume1.ozone1/sale1/@cm (ozone_key) child of ozone_bucket > o3fs://bucket1.volume1.ozone1/sale1/q1/@cm (ozone_key) child of ozone_key > o3fs://bucket1.volume1.ozone1/sale1/q1/sales/@cm (ozone_key) child of > ozone_key > > > Diffs > ----- > > addons/models/3000-Cloud/3050-ozone-typedefs.json 0f0a5c90f > common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java > c3276a891 > common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java > 4abdca498 > > > Diff: https://reviews.apache.org/r/72652/diff/1/ > > > Testing > ------- > > UTs updated & verified. > Manually verified. > > PC build: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2026/console (IN > PROGRESS) > > > Thanks, > > Nikhil Bonte > >
