----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ -----------------------------------------------------------
(Updated July 29, 2020, 1:38 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes ------- Addressed Review comments Bugs: ATLAS-3876 https://issues.apache.org/jira/browse/ATLAS-3876 Repository: atlas Description ------- **Issue:** Relationship api doesn't provide approximate count of the related entities in the response. **Workaround:** Get the total count of related given entity , irrespective of the offset/limit. Also this patch includes **improvement in the time taken to fetch related entities** . Average time taken for the Api to search relationship entities having **5000 end vertices** with limit **500**: Before : 9seconds After applying this patch : 3seconds Diffs (updated) ----- intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc47 repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 86572598a repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4b9564295 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 863a00350 repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 5069d78c8 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 Diff: https://reviews.apache.org/r/72646/diff/3/ Changes: https://reviews.apache.org/r/72646/diff/2-3/ Testing ------- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 (Failed in Impala build) Thanks, Pinal Shah