Damian,
A number of tests fail with this patch - see below. Can you please run 'mvn
clean package' and investigate these failures?
Thanks,
Madhan
Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 105.055 sec <<<
FAILURE! - in org.apache.atlas.discovery.FreeTextSearchProcessorTest
searchByNameSortBy(org.apache.atlas.discovery.FreeTextSearchProcessorTest)
Time elapsed: 0.068 sec <<< FAILURE!
java.lang.AssertionError: expected [3] but found [0]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:267)
at org.testng.Assert.assertEquals(Assert.java:277)
at
org.apache.atlas.discovery.FreeTextSearchProcessorTest.searchByNameSortBy(FreeTextSearchProcessorTest.java:91)
searchTablesByName(org.apache.atlas.discovery.FreeTextSearchProcessorTest)
Time elapsed: 0.01 sec <<< FAILURE!
java.lang.AssertionError: expected [3] but found [0]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:12T5e)
at org.testng.Assert.asssts run: 2, Failures: 0, Errors: 0, Skipped: 0,
Time elapsed: 99.643 sec - in
org.apache.atlas.services.MetricsServiceTestertEquals(Assert.java:267)
at org.testng.Assert.assertEquals(Assert.java:277)
at
org.apache.atlas.discovery.FreeTextSearchProcessorTest.searchTablesByName(FreeTextSearchProcessorTest.java:71)
Tests run: 19, Failures: 13, Errors: 0, Skipped: 0, Time elapsed: 107.395 sec
<<< FAILURE! - in org.apache.atlas.discovery.AtlasDiscoveryServiceTest
query_ALLTag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest) Time
elapsed: 0.073 sec <<< FAILURE!
java.lang.AssertionError: expected [5] but found [2]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:372)
at org.testng.Assert.assertEquals(Assert.java:382)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_ALLTag(AtlasDiscoveryServiceTest.java:125)
query_ALLTag_tagFilter(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.044 sec <<< FAILURE!
java.lang.AssertionError: expected [4] but found [1]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:372)
at org.testng.Assert.assertEquals(Assert.java:382)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_ALLTag_tagFilter(AtlasDiscoveryServiceTest.java:140)
query_ALLWildcardTag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.016 sec <<< FAILURE!
java.lang.AssertionError: expected [5] but found [2]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertEquals(Assert.java:125)
at org.testng.Assert.assertEquals(Assert.java:372)
at org.testng.Assert.assertEquals(Assert.java:382)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_ALLWildcardTag(AtlasDiscoveryServiceTest.java:165)
query_NOTCLASSIFIEDTag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.026 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_NOTCLASSIFIEDTag(AtlasDiscoveryServiceTest.java:151)
query_entity(org.apache.atlas.discovery.AtlasDiscoveryServiceTest) Time
elapsed: 0.036 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_entity(AtlasDiscoveryServiceTest.java:214)
query_entity_entityFilter(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.029 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_entity_entityFilter(AtlasDiscoveryServiceTest.java:228)
query_entity_entityFilter_tag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.017 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_entity_entityFilter_tag(AtlasDiscoveryServiceTest.java:243)
query_entity_entityFilter_tag_tagFilter(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.017 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_entity_entityFilter_tag_tagFilter(AtlasDiscoveryServiceTest.java:260)
query_entity_tag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest) Time
elapsed: 0.016 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_entity_tag(AtlasDiscoveryServiceTest.java:289)
query_entity_tag_tagFilter(org.apache.atlas.discovery.AtlasDiscoveryServiceTest)
Time elapsed: 0.012 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_entity_tag_tagFilter(AtlasDiscoveryServiceTest.java:275)
query_tag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest) Time elapsed:
0.013 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_tag(AtlasDiscoveryServiceTest.java:188)
query_tag_tagFilter(org.apache.atlas.discovery.AtlasDiscoveryServiceTest) Time
elapsed: 0.012 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_tag_tagFilter(AtlasDiscoveryServiceTest.java:202)
query_wildcardTag(org.apache.atlas.discovery.AtlasDiscoveryServiceTest) Time
elapsed: 0.015 sec <<< FAILURE!
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:496)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at
org.apache.atlas.discovery.AtlasDiscoveryServiceTest.query_wildcardTag(AtlasDiscoveryServiceTest.java:176)
Results :
Failed tests:
AtlasDiscoveryServiceTest.query_ALLTag:125 expected [5] but found [2]
AtlasDiscoveryServiceTest.query_ALLTag_tagFilter:140 expected [4] but found
[1]
AtlasDiscoveryServiceTest.query_ALLWildcardTag:165 expected [5] but found [2]
AtlasDiscoveryServiceTest.query_NOTCLASSIFIEDTag:151 expected [true] but
found [false]
AtlasDiscoveryServiceTest.query_entity:214 expected [true] but found [false]
AtlasDiscoveryServiceTest.query_entity_entityFilter:228 expected [true] but
found [false]
AtlasDiscoveryServiceTest.query_entity_entityFilter_tag:243 expected [true]
but found [false]
AtlasDiscoveryServiceTest.query_entity_entityFilter_tag_tagFilter:260
expected [true] but found [false]
AtlasDiscoveryServiceTest.query_entity_tag:289 expected [true] but found
[false]
AtlasDiscoveryServiceTest.query_entity_tag_tagFilter:275 expected [true] but
found [false]
AtlasDiscoveryServiceTest.query_tag:188 expected [true] but found [false]
AtlasDiscoveryServiceTest.query_tag_tagFilter:202 expected [true] but found
[false]
AtlasDiscoveryServiceTest.query_wildcardTag:176 expected [true] but found
[false]
FreeTextSearchProcessorTest.searchByNameSortBy:91 expected [3] but found [0]
FreeTextSearchProcessorTest.searchTablesByName:71 expected [3] but found [0]
Tests run: 756, Failures: 15, Errors: 0, Skipped: 14
On 7/29/20, 6:11 AM, "Damian Warszawski" <nore...@reviews.apache.org on behalf
of damian.warszaw...@gmail.com> wrote:
> On July 28, 2020, 10:55 p.m., Madhan Neethiraj wrote:
> > Ship It!
Can I ask you to merge it? I don't think I have permissions to merge it to
master.
- Damian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72695/#review221401
-----------------------------------------------------------
On July 25, 2020, 8:53 p.m., Damian Warszawski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72695/
> -----------------------------------------------------------
>
> (Updated July 25, 2020, 8:53 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and
Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Optional configuration to support locks on JanusGraph to ensure data
consitency.
>
> JanusGraph is eventually consistent by default which is efficient but
results in duplicates when race condition occurs.
>
>
> Reference to jira
https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-3398
>
>
> Diffs
> -----
>
>
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
6ef9cb76c
> intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca01
>
>
> Diff: https://reviews.apache.org/r/72695/diff/3/
>
>
> Testing
> -------
>
> Not possible to reproduce the error on local machine. Enable locking on
our dev env and have not introduce any regression.
>
>
> Thanks,
>
> Damian Warszawski
>
>
