----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72714/#review221584 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Aug. 14, 2020, 1:35 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72714/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 1:35 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and > Sarath Subramanian. > > > Bugs: ATLAS-3898 > https://issues.apache.org/jira/browse/ATLAS-3898 > > > Repository: atlas > > > Description > ------- > > Currently in the Atlas-Ranger plugin for types resource READ permission is > not available and read access is available by default to all types of any > category. > > This patch authorize read for all typedefs. It implicitly add read permission > if create,update or delete permission is assinged to user. > > a)Instrumented authorization code to read classification typedef endpoints in > Atlas code with create permission. > b)Added logAudit property in AtlasRequest to skip auditing for filtering > calls. > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java > 460b454b9 > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java > 95d69e685 > authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java > 7287b3dd7 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasTypesDefFilterRequest.java > PRE-CREATION > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java > 734991691 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java > 79f52700b > > > Diff: https://reviews.apache.org/r/72714/diff/2/ > > > Testing > ------- > > Done end to end testing with Atlas with SimpleAuthorizer for getAll typedefs > API, and type def API with name & guid. > > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2110 > > > Thanks, > > Nixon Rodrigues > >
