----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72869/ -----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-3942 https://issues.apache.org/jira/browse/ATLAS-3942 Repository: atlas Description ------- Problem : delete-type is triggering read-type authz access internally when called by method getByName. due to this delete-type access is depend on read-type access. This pactch propose refactoring of AtlasTypeDefGraphStore code to remove authz check reading typedef internally. Also refactore the duplicate type check and type-read authorization code , to move type-read authorization code before duplicate type check Diffs ----- intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 0b1317ad6 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java 9ffede4e3 Diff: https://reviews.apache.org/r/72869/diff/1/ Testing ------- Tested delete classfication when user do not have read access has deny access to update type. Tested creating duplicate classification type. Thanks, Nixon Rodrigues