----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72879/#review221886 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On Sept. 17, 2020, 2:26 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72879/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2020, 2:26 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and > Sarath Subramanian. > > > Bugs: ATLAS-3946 > https://issues.apache.org/jira/browse/ATLAS-3946 > > > Repository: atlas > > > Description > ------- > > Filter TypeDefs in Metrics API and show data accordingly, currently data is > shown for all types even if user do not have access to those types. > > This patch filterTypeDefs after authorization and updates the data for > required types. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/services/MetricsService.java > 7917f32e5 > webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java > e74a9e93a > > > Diff: https://reviews.apache.org/r/72879/diff/1/ > > > Testing > ------- > > Tested Statistics UI from different users with different policies for > entityType and classfication. > > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console > > > Thanks, > > Nixon Rodrigues > >
