----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72892/#review221962 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 1140 (patched) <https://reviews.apache.org/r/72892/#comment311027> #1141 below validates that the user has ENTITY_CREATE permission. I think additional validation for type-read permission is unnecessary; to restrict an user from creating entities, there should be ENTITY_CREATE policies in place. - Madhan Neethiraj On Sept. 22, 2020, 12:17 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72892/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2020, 12:17 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > and Sarath Subramanian. > > > Bugs: ATLAS-3951 > https://issues.apache.org/jira/browse/ATLAS-3951 > > > Repository: atlas > > > Description > ------- > > Bug :- User is able to create entities of type though he doesn't have read > permissions on the type. > > This patch updates the createOrUpdate entities flow to add type-read > authorization for entity-type of the entity tobe created. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 7cf77ea04 > > > Diff: https://reviews.apache.org/r/72892/diff/1/ > > > Testing > ------- > > Tried Creating entities with non authorized and authorized entity types. > > > Thanks, > > Nixon Rodrigues > >
