----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72917/#review221979 -----------------------------------------------------------
Ship it! Ship It! - keval bhatt On Sept. 30, 2020, 10:52 p.m., Deep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72917/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2020, 10:52 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, madhan, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3964 > https://issues.apache.org/jira/browse/ATLAS-3964 > > > Repository: atlas > > > Description > ------- > > In the case of a type that has an attribute of type Long, and it contains a > very large number, the Atlas UI does not show the correct number. The problem > is with client-side parsing. It's not an issue with our UI code, its a > problem on browser's javascript engine. > Javascript cannot handle values bigger than Number.MAX_SAFE_INTEGER (2^53 == > 9 007 199 254 740 992). long is 2^64, so for any number greater than 2^53, > javascript does internal optimization to maintain sanity. > > > Diffs > ----- > > dashboardv2/gruntfile.js 747de0bc7 > dashboardv2/package.json c2f7c0fc3 > dashboardv2/public/js/main.js 8caa78122 > dashboardv2/public/js/utils/Overrides.js 33328f07c > dashboardv3/gruntfile.js 378a69a04 > dashboardv3/package.json 895020068 > dashboardv3/public/js/main.js 17e336208 > dashboardv3/public/js/utils/Overrides.js 33328f07c > > > Diff: https://reviews.apache.org/r/72917/diff/1/ > > > Testing > ------- > > Testing is done with local setup. > > > Thanks, > > Deep Singh > >
