----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72908/#review222003 -----------------------------------------------------------
addons/models/0000-Area0/0010-base_model.json Lines 47 (patched) <https://reviews.apache.org/r/72908/#comment311068> SERVER_STOP and SERVER_STATE_PASSIVE is not handled yet. Consider not adding to enum if the states are not used. Review patch file, atlas audit entry as well. webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java Lines 57 (patched) <https://reviews.apache.org/r/72908/#comment311069> atlasAuditService => auditService webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java Lines 146 (patched) <https://reviews.apache.org/r/72908/#comment311071> record server start time in beginning of method, instead of calling new Date() method. Server start time and server active time should be same time. webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java Lines 56 (patched) <https://reviews.apache.org/r/72908/#comment311070> atlasAuditService => auditService - Sarath Subramanian On Oct. 7, 2020, 1:39 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72908/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2020, 1:39 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3957 > https://issues.apache.org/jira/browse/ATLAS-3957 > > > Repository: atlas > > > Description > ------- > > By using Audit Framework, capture audit entries for "Server Start" and > "Server In Active mode" (HA) > > These audit entries can be seen under the "Audits" tab of Admin section. > > > Diffs > ----- > > addons/models/0000-Area0/0010-base_model.json 1de9e57 > > addons/models/0000-Area0/patches/006-base_model_add_atlas_operation_attributes.json > a27525e > intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java > 9ed4168 > test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 > webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java > 6985291 > webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 > > > Diff: https://reviews.apache.org/r/72908/diff/2/ > > > Testing > ------- > > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console > > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull > > > Thanks, > > Mandar Ambawane > >
