----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72942/#review222007 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Oct. 9, 2020, 8:16 a.m., Deep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72942/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2020, 8:16 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3987 > https://issues.apache.org/jira/browse/ATLAS-3987 > > > Repository: atlas > > > Description > ------- > > For Atlas export, Admin priveledges are required. If such priveledges are not > there, then Export API fails with 403 status. However, the atlasClient does > not pass this information in the exception. > > AtlasServiceException did not have any constructon with another > AtlasServiceException object as parameter. > There is a constructon which takes generic Exception parameter, and does not > care about the status in the exception. > > I have added a new constructor which retains the status of passed exception. > > > Diffs > ----- > > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java 6e03669ef > client/common/src/main/java/org/apache/atlas/AtlasServiceException.java > 6b4dd1165 > > webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java > e53f9a8a6 > > > Diff: https://reviews.apache.org/r/72942/diff/1/ > > > Testing > ------- > > Unit testing > Additional unit tests added. > > > Thanks, > > Deep Singh > >
