----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72902/#review222014 -----------------------------------------------------------
intg/src/main/python/apache_atlas/base_client.py Lines 46 (patched) <https://reviews.apache.org/r/72902/#comment311086> If kerberos is not handled currently, consider adding in a subsequent patch. intg/src/main/python/apache_atlas/base_client.py Lines 60 (patched) <https://reviews.apache.org/r/72902/#comment311087> Similar to Java client, consider adding support for multiple URLs - in a subsequent patch. intg/src/main/python/apache_atlas/base_client.py Lines 90 (patched) <https://reviews.apache.org/r/72902/#comment311085> Consider checking for 'response = None', here and following if blocks: if response is None: ... else if response.status_code == api.expected_status: ... else response.status_code == HTTPStatus.SERVICE_UNAVAILABLE: ... else: intg/src/main/python/apache_atlas/model/typedef.py Lines 58 (patched) <https://reviews.apache.org/r/72902/#comment311089> Should category be constructor parameter in AtlasEnumDef, given the valuw would be ENUM for AtlasEnumDef. If this argument is needed for JSON deserialization, consider replacing default None with ENUM. Same for other classes as well: AtlasClassificationDef, AtlasEntityDef, AtlasRelationshipDef, AtlasBusinessMetadataDef, intg/src/main/python/tests/__init__.py Lines 18 (patched) <https://reviews.apache.org/r/72902/#comment311088> I suggest to move intg/src/main/python/tests tto intg/src/test/python/ - Madhan Neethiraj On Oct. 12, 2020, 7:12 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72902/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2020, 7:12 a.m.) > > > Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. > > > Bugs: ATLAS-3875 > https://issues.apache.org/jira/browse/ATLAS-3875 > > > Repository: atlas > > > Description > ------- > > This is a updated patch from https://reviews.apache.org/r/72730/ > > Few additional changes: > 1. Formatting changes > 2. Renamed atlas_client to apache_atlas > 3. Moved client and model files into intg module > 4. Updated README files. > > --------------------------------- > Added basic structure for Python client > This includes all classes for Entity and TypeDef > Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship > Added Python Sample project to test basic APIs and as a guideline > Added logging and readme file > > > Diffs > ----- > > .gitignore 90ca27646 > > atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java > e4fc4edbf > atlas-examples/sample-app/src/main/python/README.md PRE-CREATION > atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json > PRE-CREATION > > atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/request_json/typedef_create.json > PRE-CREATION > atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION > atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION > atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION > intg/src/main/python/LICENSE PRE-CREATION > intg/src/main/python/README.md PRE-CREATION > intg/src/main/python/apache_atlas/__init__.py PRE-CREATION > intg/src/main/python/apache_atlas/base_client.py PRE-CREATION > intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION > intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION > intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION > intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION > intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION > intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION > intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION > intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION > intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION > intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION > intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION > intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION > intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION > intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION > intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION > intg/src/main/python/apache_atlas/utils.py PRE-CREATION > intg/src/main/python/requirements.txt PRE-CREATION > intg/src/main/python/setup.py PRE-CREATION > intg/src/main/python/tests/__init__.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/72902/diff/2/ > > > Testing > ------- > > Local testing done > > > Thanks, > > Sarath Subramanian > >
