----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72938/#review222086 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 200 (patched) <https://reviews.apache.org/r/72938/#comment311154> why is 'uiDateTimezone' a boolean flag - do we expect a timezone value? If you are expecting a boolean value, consider giving a meaningful property name. - Sarath Subramanian On Oct. 8, 2020, 11:21 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72938/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2020, 11:21 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3984 > https://issues.apache.org/jira/browse/ATLAS-3984 > > > Repository: atlas > > > Description > ------- > > Add UI Date Timezone and UI Date Format in Session api. > > Provide a way to user to read these "UI Date Timezone" and "UI Date Format" > values from property file. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 3a6139f > > > Diff: https://reviews.apache.org/r/72938/diff/2/ > > > Testing > ------- > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console > > > Thanks, > > Mandar Ambawane > >
