> On Oct. 23, 2020, 5:26 a.m., Sarath Subramanian wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > > Line 268 (original) > > <https://reviews.apache.org/r/72986/diff/1/?file=2241504#file2241504line271> > > > > how is embedded solr service shutdown? now the call is removed during > > cleanup()
Good catch Sarath! Thanks. For UTs, embedded Solr shutdown is handled by from one of the following methods: - AbstractGraphDatabaseTest.cleanUp() - AtlasJanusDatabaseTest.cleanUp() - JanusGraphProviderTest.tearDown() - AtlasTestBase.cleanup() For ITs, shutdown needs to be added in AtlasJanusGraphDatabase.java, similar to handling of startup. Patch updated with this fix. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72986/#review222106 ----------------------------------------------------------- On Oct. 23, 2020, 5:49 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72986/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2020, 5:49 a.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil > Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra. > > > Repository: atlas > > > Description > ------- > > - refactored UTs and ITs to minmized references to LocalSolrRunner/Solr test > framework > - removed compile time dependency to atlas-testtools from non-test code > (repository, graphdb/janus/webapp modules) > > > Diffs > ----- > > graphdb/janus/pom.xml 6deef5181 > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java > e9b4b09ef > graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java > 6509fef6b > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java > 35004157f > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java > 5cd55093e > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java > 54b1bc621 > pom.xml 91fd593d8 > repository/pom.xml 861896267 > > repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java > d9981e6f6 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > e35f3594f > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 270051fdc > repository/src/test/java/org/apache/atlas/TestModules.java a298934f3 > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > d8c1546e2 > > repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java > 869345921 > > repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java > db107b377 > > repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java > 2a38d874d > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 5ace37944 > repository/src/test/java/org/apache/atlas/repository/AtlasTestBase.java > c2668b195 > > repository/src/test/java/org/apache/atlas/repository/audit/AdminPurgeTest.java > 173e446e5 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java > 8e19dc4d3 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportReactivateTableTest.java > e06bf66d1 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > 7367153ec > > repository/src/test/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractorTest.java > 5f41cc968 > > repository/src/test/java/org/apache/atlas/repository/impexp/TableReplicationRequestProcessorTest.java > 99df914ff > > repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java > bd8359c4f > > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java > b654638f1 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityDefStoreV2Test.java > 587624834 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityTestBase.java > 752f1acfc > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2Test.java > 1a774e2a1 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2Test.java > 4cdd677e5 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/InverseReferenceUpdateV2Test.java > 36aedae9f > > repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java > 80e20bed8 > > repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java > eeab3bca2 > repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java > 4739bca31 > test-tools/pom.xml 434d15c1b > test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java > 2c79e2f51 > webapp/pom.xml ffc3d37ef > webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java > 417a19ace > > > Diff: https://reviews.apache.org/r/72986/diff/2/ > > > Testing > ------- > > - precommit tests run: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/121 > > > Thanks, > > Madhan Neethiraj > >
