-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73022/
-----------------------------------------------------------

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-4032
    https://issues.apache.org/jira/browse/ATLAS-4032


Repository: atlas


Description
-------

In the existing code we are not including the Inner Criterias of the Filter.

Also the Condition of the Outer filter was getting applied to the Inner Filters 
groups.

In this patch, code refactoring is done. The code which populate the Filter 
Criteria is now removed.

Instead of doing it from Server end, This patch keeps the Filter Criteria in 
the same format which UI has sent.

Additionally this patch provides validation for the Filter Criteria 1.Attribute 
Name 2. Attribute Value and 3.Operator
This validation goes until the last level of the Inner Filter Criterias.


Diffs
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa9 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 d843204 


Diff: https://reviews.apache.org/r/73022/diff/1/


Testing
-------

Manual testing is done for the scenarios where Filter Groups are included.

Earlier it was not giving expected search result.

With this patch we can get the expected result in the Admin Audit Search.


Thanks,

Mandar Ambawane

Reply via email to