> On Nov. 20, 2020, 8:04 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 77 (patched)
> > <https://reviews.apache.org/r/73029/diff/2/?file=2242081#file2242081line77>
> >
> >     clientId => clientIp
> 
> Deep Singh wrote:
>     Madhan, Variable will not contain IP all the time. Sometime it could be 
> IP, sometime it could be combination of host name and IP. I think 'clientId' 
> is an appropriate name for the variable.

Ok. I agree. Thanks!


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73029/#review222220
-----------------------------------------------------------


On Nov. 20, 2020, 4:05 p.m., Deep Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73029/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2020, 4:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4036 and ATLAS-4037
>     https://issues.apache.org/jira/browse/ATLAS-4036
>     https://issues.apache.org/jira/browse/ATLAS-4037
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> For System operations like TYPE_DEF_CREATE, TYPE_DEF_UPDATE, SERVER_START and 
> SERVER_STATE_ACTIVE the users field and client Id was empty. With this fix, 
> we now have falback strategies. We first try to get user from request 
> context, if it is not found then it is assumed that the operation is donw by 
> system user(atlas). Similarly clientId is first determined using IP address 
> information in request context, if not found we fallback to JDK InetAddress 
> apis to fetch hostname and ip address, if not found there as well, we log 
> clientId as "unknown"
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  d843204f2 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
>  bfc300ec9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  ed17b927e 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java befd726ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 4db477eef 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 1d1e08e43 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 
> 93e6513ff 
> 
> 
> Diff: https://reviews.apache.org/r/73029/diff/2/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Deep Singh
> 
>

Reply via email to