> On Nov. 25, 2020, 3:58 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > > Lines 302 (patched) > > <https://reviews.apache.org/r/73035/diff/1/?file=2242120#file2242120line303> > > > > It looks like 'term' is only used to retrieve guid of the associated > > glossary (in the following line). Consider avoiding retrieval of entire > > term, by adding a method GlossaryService.getGlossaryGuidForTerm(String > > termGuid).
I have a different approach for this that avoids the need for additional method. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73035/#review222235 ----------------------------------------------------------- On Nov. 30, 2020, 5:52 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73035/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2020, 5:52 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Sarath > Subramanian. > > > Bugs: ATLAS-4024 > https://issues.apache.org/jira/browse/ATLAS-4024 > > > Repository: atlas > > > Description > ------- > > **Background** > Existing _Export Service_ support export of _AtlasGlossary_. The incremental > export option does not support Glossary. > > This patch addresses that problem. > > **Solution** > Add extraction steps when processing entities. > *Modified* _EntityService_: Additional steps for Term and Glossary extraction. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > 8af20576d > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java > a85db5cd5 > > > Diff: https://reviews.apache.org/r/73035/diff/2/ > > > Testing > ------- > > **Functional tests** > Performed export-import-export and compare. > > **Pre-commit Build** > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/216/ > > > Thanks, > > Ashutosh Mestry > >
