----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73072/#review222319 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java Line 68 (original), 67 (patched) <https://reviews.apache.org/r/73072/#comment311377> add check to see if updatedTypes is not empty as well. if (CollectionUtils.isNotEmpty(createdTypes) && CollectionUtils.isNotEmpty(updatedTypes) && createdTypes.size() == updatedTypes.size()) As an added check verify if the typeName matches in both list before assigning updated typeDefs to created typeDefs - Sarath Subramanian On Dec. 8, 2020, 3:44 a.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73072/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2020, 3:44 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4065 > https://issues.apache.org/jira/browse/ATLAS-4065 > > > Repository: atlas > > > Description > ------- > > This issue is coming from the Atlas Framework itself. > > For every TypeDef Create operation there is subsequent Update call. > > Similarly for every TypeDef Update operation there is subsequent Update call. > > Some attributes are not getting set in the first Create / Update call of the > TypeDef. Instead, they are getting set in the subsequent Update call. > > This patch handles all these scenarios. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java > 4fe9f59 > > > Diff: https://reviews.apache.org/r/73072/diff/1/ > > > Testing > ------- > > > Thanks, > > Mandar Ambawane > >
