Verdan,

This one started as an update to support Kerberos authentication. Given the 
library uses requests package, for Kerberos support I tried requests_kerberos 
package. However, installing this package for python3 failed in some of my 
Linux environments. Hence looked into enabling Python 2.7 for Atlas library, 
which by itself wasn't much change.

Most of the updates in this patch are about using instances of Atlas classes 
(like AtlasEntity) for both API arguments and return values. In earlier 
version, API arguments were Atlas class instances, but the return value was an 
dict - which would make it confusing to deal with.

Thanks,
Madhan

On 12/11/20, 1:07 PM, "Verdan Mahmood" <[email protected]> wrote:

    A quick question Madhan, any specific requirements to support Python 2.7,
    as it’s EOL is end of this year?

    On Fri, 11 Dec 2020 at 22:04, Madhan Neethiraj <[email protected]> wrote:

    >
    > -----------------------------------------------------------
    > This is an automatically generated e-mail. To reply, visit:
    > https://reviews.apache.org/r/73078/
    > -----------------------------------------------------------
    >
    > (Updated Dec. 11, 2020, 9:03 p.m.)
    >
    >
    > Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues,
    > Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
    >
    >
    > Changes
    > -------
    >
    > updated README.txt
    >
    >
    > Summary (updated)
    > -----------------
    >
    > ATLAS-4077: updated Atlas Python client to work with Python 2.7
    >
    >
    > Bugs: ATLAS-4077
    >     https://issues.apache.org/jira/browse/ATLAS-4077
    >
    >
    > Repository: atlas
    >
    >
    > Description
    > -------
    >
    > updated Atlas Python client to work with Python 2.7
    >
    >
    > Diffs (updated)
    > -----
    >
    >   atlas-examples/sample-app/src/main/python/discovery_example.py 93aae1d88
    >   atlas-examples/sample-app/src/main/python/entity_example.py 2cd5da122
    >   atlas-examples/sample-app/src/main/python/glossary_example.py ab5e20170
    >   atlas-examples/sample-app/src/main/python/lineage_example.py 42e2398d3
    >
    > 
atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json
    > c6f8a87db
    >
    > 
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
    > f59ec48da
    >
    > 
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
    > 8838841a1
    >
    > 
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
    > 9685e8d54
    >
    > atlas-examples/sample-app/src/main/python/request_json/typedef_create.json
    > b42781ad9
    >   atlas-examples/sample-app/src/main/python/sample_client.py 54720d9ab
    >   atlas-examples/sample-app/src/main/python/typedef_example.py 8431d70dd
    >   atlas-examples/sample-app/src/main/python/utils.py c19382f29
    >   intg/src/main/python/README.md 086d7775f
    >   intg/src/main/python/apache_atlas/base_client.py ba85018e8
    >   intg/src/main/python/apache_atlas/client/discovery.py b1cdcc62e
    >   intg/src/main/python/apache_atlas/client/entity.py d43408e5d
    >   intg/src/main/python/apache_atlas/client/glossary.py 41b977e1f
    >   intg/src/main/python/apache_atlas/client/lineage.py e8966c2f3
    >   intg/src/main/python/apache_atlas/client/relationship.py 9ccf6444d
    >   intg/src/main/python/apache_atlas/client/typedef.py 70f795f5d
    >   intg/src/main/python/apache_atlas/exceptions.py d306568a5
    >   intg/src/main/python/apache_atlas/model/discovery.py 18eca380f
    >   intg/src/main/python/apache_atlas/model/entity.py ea66e717c
    >   intg/src/main/python/apache_atlas/model/enums.py PRE-CREATION
    >   intg/src/main/python/apache_atlas/model/glossary.py a9958d57e
    >   intg/src/main/python/apache_atlas/model/instance.py PRE-CREATION
    >   intg/src/main/python/apache_atlas/model/lineage.py 9e9c6e139
    >   intg/src/main/python/apache_atlas/model/metrics.py PRE-CREATION
    >   intg/src/main/python/apache_atlas/model/misc.py PRE-CREATION
    >   intg/src/main/python/apache_atlas/model/profile.py PRE-CREATION
    >   intg/src/main/python/apache_atlas/model/relationship.py 64a59eda8
    >   intg/src/main/python/apache_atlas/model/typedef.py 480d9fe32
    >   intg/src/main/python/apache_atlas/utils.py a59f29f1e
    >   intg/src/main/python/setup.py 60f49d2de
    >
    >
    > Diff: https://reviews.apache.org/r/73078/diff/2/
    >
    > Changes: https://reviews.apache.org/r/73078/diff/1-2/
    >
    >
    > Testing (updated)
    > -------
    >
    > - verified that the sample client works with Python 2.7 and Python 3.7
    > - updated APIs to return Atlas class objects, instead of a dict object, to
    > enable consistent access to members
    > - verified with HTTPS and Kerberos authentication
    > - reorg classes to be in sync with Java client
    > - simplified json files used by sample for easier reading
    >
    >
    > Thanks,
    >
    > Madhan Neethiraj
    >
    > --
    Sent from my iPhone


Reply via email to