-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73085/#review222336
-----------------------------------------------------------




intg/src/main/python/apache_atlas/model/metrics.py
Lines 29 (patched)
<https://reviews.apache.org/r/73085/#comment311401>

    I suggest to retain self.data as well, since the metrics API sends 
additional keys - like system.
      self.data    = attrs.get('data', {})
      self.general = self.data.get('general', {})
      self.tag     = self.data.get('tag', {})
      self.entity  = self.data.get('entity', {})


- Madhan Neethiraj


On Dec. 14, 2020, 9:12 p.m., Verdan Mahmood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73085/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2020, 9:12 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Pinal Shah, and Sarath 
> Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This review request implements the admin metrics endpoint, and also bumps the 
> version of python client to "0.0.3"
> 
> **Usage:**
> 
> from apache_atlas.client.base_client import AtlasClient
> 
> client = AtlasClient('http://localhost:21000', ('admin', 'admin'))
> 
> client.admin.get_metrics()
> 
> 
> Diffs
> -----
> 
>   intg/src/main/python/apache_atlas/client/admin.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/base_client.py 
> 3e6002db8cc40530e6deef182114bdc176d6c7ef 
>   intg/src/main/python/apache_atlas/model/metrics.py 
> 636a3ea265cf6f216ed8b653d594652ac35de35a 
>   intg/src/main/python/setup.py ed33ebefc84acde17b75c109bc3b797b4499d124 
> 
> 
> Diff: https://reviews.apache.org/r/73085/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Verdan Mahmood
> 
>

Reply via email to