> On Dec. 29, 2020, 2:06 a.m., Madhan Neethiraj wrote:
> > Ship It!
> 
> Verdan Mahmood wrote:
>     How do you guys verify these changes? How did you test it Madhan? This 
> gives me a ciruclar import errors for each call. 
>     Perhaps I missed anything.

I've tested it locally but must've added some changes afterwards. Client has no 
test coverage yet, this should be next step I think to add unit tests run in 
CI. In the meantime please test https://reviews.apache.org/r/73112/ to check if 
that resolved your issue (I've reverted import approach in instance module to 
previous one). It did in my case - tested by running examples in README.md.

The version before refactoring contained several issues fixed in this MR (like 
several functions with same names but different arguments which is a no-go in 
Python).


- Mariusz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73109/#review222390
-----------------------------------------------------------


On Dec. 28, 2020, 12:36 p.m., Mariusz Górski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73109/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2020, 12:36 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Verdan Mahmood.
> 
> 
> Bugs: ATLAS-4089
>     https://issues.apache.org/jira/browse/ATLAS-4089
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> * As agreed in https://reviews.apache.org/r/73097/
> * Autoformatted code to PEP8
> * Fixed linting issues after running flake8
> * Fixed static type issues after running mypy
> 
> 
> Diffs
> -----
> 
>   intg/src/main/python/Makefile PRE-CREATION 
>   intg/src/main/python/apache_atlas/__init__.py 4aa54b866 
>   intg/src/main/python/apache_atlas/client/__init__.py f1155945f 
>   intg/src/main/python/apache_atlas/client/admin.py 171bcf8c5 
>   intg/src/main/python/apache_atlas/client/base_client.py fe0ddf40a 
>   intg/src/main/python/apache_atlas/client/discovery.py 5bead22e7 
>   intg/src/main/python/apache_atlas/client/entity.py ebfe27f9a 
>   intg/src/main/python/apache_atlas/client/glossary.py ed7acdf41 
>   intg/src/main/python/apache_atlas/client/lineage.py 980efcd2c 
>   intg/src/main/python/apache_atlas/client/relationship.py 72b701ab1 
>   intg/src/main/python/apache_atlas/client/typedef.py 2ee8f5a9e 
>   intg/src/main/python/apache_atlas/exceptions.py 839befa6c 
>   intg/src/main/python/apache_atlas/model/__init__.py f1155945f 
>   intg/src/main/python/apache_atlas/model/admin.py 3be8a94f5 
>   intg/src/main/python/apache_atlas/model/discovery.py 61a992ce7 
>   intg/src/main/python/apache_atlas/model/enums.py a5064f576 
>   intg/src/main/python/apache_atlas/model/glossary.py c81e333c3 
>   intg/src/main/python/apache_atlas/model/instance.py 89dbe3505 
>   intg/src/main/python/apache_atlas/model/lineage.py 01ba08a11 
>   intg/src/main/python/apache_atlas/model/misc.py 23d0d2fb5 
>   intg/src/main/python/apache_atlas/model/profile.py 4c2770218 
>   intg/src/main/python/apache_atlas/model/relationship.py 58bfd1bd1 
>   intg/src/main/python/apache_atlas/model/typedef.py f6fdf1afd 
>   intg/src/main/python/apache_atlas/utils.py 8384dc555 
>   intg/src/main/python/requirements-dev.txt PRE-CREATION 
>   intg/src/main/python/setup.py f11fa55ad 
>   intg/src/main/python/tox.ini PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73109/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>

Reply via email to