----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73115/#review222418 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java Lines 986 (patched) <https://reviews.apache.org/r/73115/#comment311473> consider combining if condition in 986 into 985 to avoid nested-if statements - Sarath Subramanian On Jan. 6, 2021, 11:05 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73115/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2021, 11:05 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-4069 > https://issues.apache.org/jira/browse/ATLAS-4069 > > > Repository: atlas > > > Description > ------- > > In method DeleteHandlerV1.deleteVertex() > Currently code fetches only Incoming edges of the Vertex to be deleted. > > This patch does the following > > 1. Fetches all the Outgoing edges of the Vertex. > 2. Iterates on each edge and then fetches the Vertex on the other side of the > edge (InVertex) > 3. It checks the status of that particular vertex. > 4. If that vertex is already deleted then only the current edge goes for soft > deletion. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 7b2e2d3 > > > Diff: https://reviews.apache.org/r/73115/diff/1/ > > > Testing > ------- > > Manual Testing is done. > > PreCommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/291/console > > > Thanks, > > Mandar Ambawane > >
