----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73150/#review222506 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Jan. 21, 2021, 4:25 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73150/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2021, 4:25 a.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil > Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, and > Sidharth Mishra. > > > Bugs: ATLAS-2932 > https://issues.apache.org/jira/browse/ATLAS-2932 > > > Repository: atlas > > > Description > ------- > > minor updates and refactoring to improve readability > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphTraversal.java > 946610cbd > repository/src/main/java/org/apache/atlas/query/AtlasDSL.java 777d19473 > repository/src/main/java/org/apache/atlas/query/DSLVisitor.java ce95b76bc > repository/src/main/java/org/apache/atlas/query/GremlinQuery.java e4c217c02 > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > c36f5b005 > repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java > 70685d8ac > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > c479af714 > > repository/src/main/java/org/apache/atlas/query/executors/ScriptEngineBasedExecutor.java > fc84499d4 > > repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java > a104f1997 > > repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java > a61d1d085 > repository/src/test/java/org/apache/atlas/query/BaseDSLComposer.java > 0044eac30 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 0b018949d > repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java > 6839620bd > > > Diff: https://reviews.apache.org/r/73150/diff/1/ > > > Testing > ------- > > - manually verified that 'mvn clean package' and 'mvn clean install' succeeded > - pre-commit tests run: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/345/ > > > Thanks, > > Madhan Neethiraj > >
