----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73160/#review222551 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On Feb. 3, 2021, 8:16 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73160/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2021, 8:16 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4112 > https://issues.apache.org/jira/browse/ATLAS-4112 > > > Repository: atlas > > > Description > ------- > > **Problem:** While searching with wildcard search i.e contains, beginsWith, > endsWith operator, which has escape characters in search attribute value > gives incorrect results > > **Example:** While searching qualifiedName beginsWith > "default.datagen_table_sensitive_725_1." > > **Solution:** Remove quotes and wildcard '*' from query > > **Steps to reproduce:** > 1. Create a hive_table with name ends with a digit: > datagen_table_sensitive_725_1 > 2. Search By Type: hive_columns and select attribute filter: qualifiedName as > "default.datagen_table_sensitive_725_1." shows no Records found but if > qualifiedName is changed to "default.datagen_table_sensitive_725_1" it shows > results with qualifiedName of column > "default.datagen_table_sensitive_725_1.col1@cm" > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 050980994 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 01daf53d2 > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > 0da60d37f > > > Diff: https://reviews.apache.org/r/73160/diff/3/ > > > Testing > ------- > > Added unit test cases > Precommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/353/console > > > Thanks, > > Pinal Shah > >
