-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/
-----------------------------------------------------------

(Updated Feb. 8, 2021, 4:15 p.m.)


Review request for atlas, Jayendra Parab, Nikhil Bonte, and Nixon Rodrigues.


Bugs: ATLAS-4147
    https://issues.apache.org/jira/browse/ATLAS-4147


Repository: atlas


Description
-------

Pass unsupported file type to the glossary term bulk import

curl --request POST -u user:password 
'https://<cluster>/api/atlas/v2/glossary/import' \
  -H 'Accept: application/json' \
  -H 'Cache-Control: no-cache' \
  -H 'X-Requested-With: XMLHttpRequest' \
  -H 'X-XSRF-HEADER: ""' \
  -H 'Content-Type: multipart/form-data' \
  -F [email protected] \
  --compressed \
  --insecure
  
Expectation:
Instead of "file type {0}" actual file type should be displayed

Suggestion:

Along with the above message, display the supported file format too


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java 71ac9e309 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
54e00a4bd 
  repository/src/test/resources/csvFiles/incorrectEXT.py PRE-CREATION 


Diff: https://reviews.apache.org/r/73176/diff/2/

Changes: https://reviews.apache.org/r/73176/diff/1-2/


Testing
-------

When passed above request:
{"errorCode":"ATLAS-400-00-098","errorMessage":"The provided file type: 
template_2122.py is not supported expected file formats .csv, .xls."


Thanks,

chaitali

Reply via email to