> On Feb. 10, 2021, 7:44 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > > Lines 1055 (patched) > > <https://reviews.apache.org/r/73181/diff/1/?file=2246109#file2246109line1055> > > > > why qualifiedName needs to be sent back? if 'duplicateTermHeaders' has > > any value then this confirms the terms are duplicated? Please review.
Yes Sarath, if 'duplicateTermHeaders' has any value then this confirms the terms are duplicated. Here, I am sending back First-Found Duplicate Term's QualifiedName. And including this QualifiedName in the Error Response. I am using this QualifiedName as a flag to throw an Exception. - Mandar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73181/#review222584 ----------------------------------------------------------- On Feb. 10, 2021, 1 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73181/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2021, 1 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, > Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-4146 > https://issues.apache.org/jira/browse/ATLAS-4146 > > > Repository: atlas > > > Description > ------- > > This patch checks whether any duplicate Related Glossary Terms present in the > payload sent by UI for Update operation. > > This check is done for all the GlossaryTerm Relations. > > If duplicate entry is found then Exception is thrown. > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 82243e2 > > > Diff: https://reviews.apache.org/r/73181/diff/1/ > > > Testing > ------- > > Manual Testing is done > > > Thanks, > > Mandar Ambawane > >
