----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/#review222605 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Feb. 17, 2021, 7:12 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73185/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2021, 7:12 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-4155 > https://issues.apache.org/jira/browse/ATLAS-4155 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Modify: _NotificaitonHookConsumer_: Add lastOffsetToCommit. Update this on > every commit called. Call the new method on > _AtlasKafkaConsumer.receiveWithCheckedCommit_ > - Modify: _AtlasKafkaConsumer_: Add new method _receiveWithCheckedCommit_. > > > Diffs > ----- > > notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java > c38a504fa > > notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java > f3e81ecc2 > > notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java > 05d0d8137 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 0e58dacff > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java > 33191a7a6 > > > Diff: https://reviews.apache.org/r/73185/diff/4/ > > > Testing > ------- > > **PC Build** > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/392/ > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/406/ > > **Functional tests** > Large message payload. > > > Thanks, > > Ashutosh Mestry > >
