-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73197/#review222623
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Line 520 (original), 520 (patched)
<https://reviews.apache.org/r/73197/#comment311781>

    For better clarity, consider narrowing 'try' block to  #533:
      AtlasEntityHeader entityHeader = 
entityRetriever.toAtlasEntityHeaderWithClassifications(vertex);
        
      try {
        AtlasAuthorizationUtils.verifyAccess(new 
AtlasEntityAccessRequest(typeRegistry, AtlasPrivilege.ENTITY_DELETE, 
entityHeader), "delete entity: guid=", guid);
      } catch (AtlasBaseException e) {
        if (RequestContext.get().isSkipFailedEntities()) {
          if (LOG.isDebugEnabled()) {
            LOG.debug("deleteByIds(): ignoring failure for entity {}: error 
code={}, message={}", guid, e.getAtlasErrorCode(), e.getMessage());
          }
          
          continue;
        }
        
        throw e;
      }
      
      deletionCandidates.add(vertex);



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Lines 539 (patched)
<https://reviews.apache.org/r/73197/#comment311782>

    createOrUpdate => deleteByIds


- Madhan Neethiraj


On Feb. 22, 2021, 9:48 a.m., chaitali wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73197/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2021, 9:48 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nikhil Bonte, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4171
>     https://issues.apache.org/jira/browse/ATLAS-4171
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> We need to implement one of the flag ignoreUnauthorisedGuids, 
> isSkipFailedEntities, skipFailedEntities similar to Bulk create/update entity 
> POST API
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  e6fe306e3 
> 
> 
> Diff: https://reviews.apache.org/r/73197/diff/1/
> 
> 
> Testing
> -------
> 
> When skipFailedEntities passed as a flag true only authorised entities get 
> deleted skipping unauthorised .
> 
> 
> Thanks,
> 
> chaitali
> 
>

Reply via email to