Review Request 73210: ATLAS-3976 : On creating a type with a type_name that already exists as a read-only user 409 is thrown instead on 403

[chaitali]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73210/
-----------------------------------------------------------

Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-3976
    https://issues.apache.org/jira/browse/ATLAS-3976


Repository: atlas


Description
-------

This is reproducible on struct, entity and relationship types. It works fine on 
classification, business_metadata and enum types

{'errorCode': 'ATLAS-409-00-001', 'errorMessage': 'Given type 
read_auth_struct_zEFBP already exists'} 
{'errorCode': 'ATLAS-409-00-001', 'errorMessage': 'Given type 
read_auth_entity_EfAyL already exists'} 
{'errorCode': 'ATLAS-409-00-001', 'errorMessage': 'Given type 
non_read_relationship_ENshy already exists'}


Diffs
-----

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityDefStoreV2.java
 b86cd91af 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEnumDefStoreV2.java
 2abfcf824 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java
 cf316eab1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java
 0c13a78b3 


Diff: https://reviews.apache.org/r/73210/diff/1/


Testing
-------

errorcode after fix 
{
    "errorCode": "ATLAS-403-00-001",
    "errorMessage": "admin is not authorized to perform create entity-def 
dharsh_entity_1"
}


Thanks,

chaitali