----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73213/#review222650 -----------------------------------------------------------
Ship it! https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/422/console - Nixon Rodrigues On March 2, 2021, 3:45 p.m., Deep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73213/ > ----------------------------------------------------------- > > (Updated March 2, 2021, 3:45 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4183 > https://issues.apache.org/jira/browse/ATLAS-4183 > > > Repository: atlas > > > Description > ------- > > We have Servlet 2.3 deployment descriptor (web.xml), which follows J2EE 1.3 > DTDs schema. > Therefore it requires dtd resource hosted at > http://java.sun.com/dtd/web-app_2_3.dtd > > In setups that are behind firewalls with limited access to external > resources, the Atlas server fails to come up without the external dtd > resource. > > This can be fixed by hosting dtd resource locally or upgrading the deployment > descriptor. > > We can upgrade it to Servlet 2.5 deployment descriptor which is Java EE 5 XML > schema and it does not require external dtd resource for validation. > > > Diffs > ----- > > webapp/src/test/webapp/WEB-INF/web.xml 2388fbfbb > > > Diff: https://reviews.apache.org/r/73213/diff/1/ > > > Testing > ------- > > Manual testing was done. > > > Thanks, > > Deep Singh > >
