----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73229/#review222697 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On March 15, 2021, 5:14 a.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73229/ > ----------------------------------------------------------- > > (Updated March 15, 2021, 5:14 a.m.) > > > Review request for atlas, Jayendra Parab, Nikhil Bonte, and Nixon Rodrigues. > > > Bugs: ATLAS-4180 > https://issues.apache.org/jira/browse/ATLAS-4180 > > > Repository: atlas > > > Description > ------- > > Input: @ in term name > > "glossary_1","@term_1" > Error: > > {"errorCode":"ATLAS-500-00-016","errorMessage":"Error occurred while creating > glossary term: {0}","errorCause":"name cannot contain following special chars > (@, .)"} > Expectation: > > Replace * {0} > * with actual term name > > Convey the reason in error message > > > Input: @ in glossary name > > "@glossary_1","term_1" > Error: > > {"errorCode":"ATLAS-500-00-001","errorMessage":"The uploaded file has not > been processed due to the following errors : \n[The provided Glossary Name is > invalid : @glossary_1]"} > Expectation: > > Keep it consistent with above message > convey reason in error message > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > df5fcbd72 > > > Diff: https://reviews.apache.org/r/73229/diff/1/ > > > Testing > ------- > > > Thanks, > > chaitali > >
