----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73244/#review222720 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On March 18, 2021, 9:23 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73244/ > ----------------------------------------------------------- > > (Updated March 18, 2021, 9:23 p.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil > Bonte, Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, and > Sidharth Mishra. > > > Bugs: ATLAS-4215 > https://issues.apache.org/jira/browse/ATLAS-4215 > > > Repository: atlas > > > Description > ------- > > Notification module finds the directory to write its log file by inspecting > log4j appender instances at runtime. It first checks for appenders in > org.apache.logging.log4j; when none is found here, it looks for appenders in > org.apache.log4j. However, this doesn't handle components (like HBase 2.3.3) > that don't have org.apache.logging.log4j library in the classpath - which > results in such services to fail initialization. > > Updated notification module to gracefully handle absense of > org.apache.logging.log4j library. > > > Diffs > ----- > > > notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java > dc98592bd > > > Diff: https://reviews.apache.org/r/73244/diff/1/ > > > Testing > ------- > > - verified that Atlas HBase hook work with HBase 2.3.3 > - pre-commit tests run: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/460/ > > > Thanks, > > Madhan Neethiraj > >
