> On March 31, 2021, 6:38 p.m., Sarath Subramanian wrote: > > common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java > > Line 220 (original), 234 (patched) > > <https://reviews.apache.org/r/73261/diff/1/?file=2248307#file2248307line234> > > > > is this intentional change in aws?
Yes this is to take care of correct objectPrefix value in case of path entity for Aws S3. - Sidharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73261/#review222753 ----------------------------------------------------------- On March 30, 2021, 11:37 p.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73261/ > ----------------------------------------------------------- > > (Updated March 30, 2021, 11:37 p.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-4230 > https://issues.apache.org/jira/browse/ATLAS-4230 > > > Repository: atlas > > > Description > ------- > > Create new entity for Google cloud storage location from hive > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/utils/AtlasPathExtractorUtil.java > 81f847e75 > common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java > dbc500043 > > > Diff: https://reviews.apache.org/r/73261/diff/1/ > > > Testing > ------- > > UT updated and manually tested if the GCP entities are created appropriately. > > > Thanks, > > Sidharth Mishra > >
