----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73271/ -----------------------------------------------------------
(Updated April 14, 2021, 6:40 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes ------- addressed comments Bugs: ATLAS-4238 https://issues.apache.org/jira/browse/ATLAS-4238 Repository: atlas Description ------- **Current working:** During freetext/quick search, wildcard '*' is appended after the search string from UI. Whenever attribute search value has "**+-&|!(){}[]^"~?:**" special characters, then '*' will not be appended to get the correct result. ('*' is removed because for TEXT type attribute, it tokenize the value on special characters) **Issue:** '@' or 'digit+.' etc there are many other special characters which gets tokenize for 'TEXT' type attribute. hence if the search value has these special characters which are not added in above list, it doesn't give results. **Solution:** We need to handle all the special characters which tokenize the string **Note:** This patch doesn't handle escaping special characters when search as part of freetext search - Whenever user tends to search for **'STRING'** type attribute example: 'name' i. **Client has to escape 'space'** ii.**For the partial search, client has to append '*' ** Example: to search string with name = sales department@hdfc, user has to search like sales\ department* - Whenever user tends to search for **'TEXT'** type attribute example: 'qualifiedName' i. **No Need of escape 'space'**. If it is escaped partial search will not work ii.**For partial search, no need of appending '*' ** Example: to search string with qualifiedName = sales department@hdfc, user has to search like sales department or sales\ department@hdfc Diffs (updated) ----- repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4ae2d1279 repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java 9846d4310 Diff: https://reviews.apache.org/r/73271/diff/3/ Changes: https://reviews.apache.org/r/73271/diff/2-3/ Testing ------- added test cases Precommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/487/console Thanks, Pinal Shah