----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72644/#review222823 -----------------------------------------------------------
Ship it! Ship It! - Pinal Shah On April 8, 2021, 1:01 p.m., Mandar Ambawane wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72644/ > ----------------------------------------------------------- > > (Updated April 8, 2021, 1:01 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3872 > https://issues.apache.org/jira/browse/ATLAS-3872 > > > Repository: atlas > > > Description > ------- > > Cause of the problem: > Type-def Column is created by quick-start script. > > Here in this case, Type-def Column has the attribute "name". And it has > property isOptional = true > > Type-def Column is a child of Type-def Asset which also has the attribute > "name". And it has property isOptional = false > > Now while creating Entity of Type-def Column from UI, it does not show > attribute "name" in the mandatory fields because for Type-def Column its > property isOptional = true > > But while validating the attributes from server side we iterate through all > the attributes of Entity type (Including Parent's attributes) > In this case, while validating Type-def Asset's attribute "name" (which has > property isOptional = false) we get an error because its value is sent as > "null" from UI side. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 773fae2 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 22259bc > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 27c7f73 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java d89aca2 > intg/src/test/java/org/apache/atlas/TestUtilsV2.java 80ab6b4 > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df9525 > repository/src/test/resources/logging-v1-full.zip > 69c54eec000964a1f6f3fef96b26cca188a28ba1 > repository/src/test/resources/sales-v1-full.zip > 07afbf6ecae312a840b54cae5ab01335c513d180 > repository/src/test/resources/salesNewTypeAttrs-next.zip > e4c8505be1587fb7cc8b6354bdda701e9557da99 > repository/src/test/resources/salesNewTypeAttrs.zip > a4467e641fffb10189288fb2f26dc4fbc06bbd42 > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > 6db6b58 > > webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java > 0cd707f > > webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java > 7c820e7 > > > Diff: https://reviews.apache.org/r/72644/diff/7/ > > > Testing > ------- > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console > > PreCommit: > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2088/console > > > Thanks, > > Mandar Ambawane > >
