----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73249/#review222873 -----------------------------------------------------------
distro/src/bin/atlas_start.py Line 135 (original), 138 (patched) <https://reviews.apache.org/r/73249/#comment312044> What happens if the collection name, updated in properties already exists in solr Can we restrict this from not allowing to point old collection? repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java Lines 43 (patched) <https://reviews.apache.org/r/73249/#comment312046> Can you set collection names here? repository/src/test/resources/atlas-application.properties Lines 1 (patched) <https://reviews.apache.org/r/73249/#comment312047> Can you please review if this is required? - Pinal Shah On April 26, 2021, 5:41 a.m., chaitali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73249/ > ----------------------------------------------------------- > > (Updated April 26, 2021, 5:41 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > Pinal Shah, and Sarath Subramanian. > > > Bugs: ATLAS-4221 > https://issues.apache.org/jira/browse/ATLAS-4221 > > > Repository: atlas > > > Description > ------- > > Currently in Atlas, the collection names are not configurable > > We need to provide functionality where in names of the solr collections can > be customized using property configuration > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 > distro/src/bin/atlas_config.py 80b3bfb78 > distro/src/bin/atlas_start.py 7cf35a92a > distro/src/conf/atlas-application.properties e06e74a26 > intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 > repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java > PRE-CREATION > repository/src/test/resources/atlas-application.properties PRE-CREATION > > tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java > 37565188e > > > Diff: https://reviews.apache.org/r/73249/diff/6/ > > > Testing > ------- > > mvn clean install > mvn clean package -Pdist,embedded-hbase-solr > atlas server up and running > Collections created with entities linked > > > Thanks, > > chaitali > >
