----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73310/#review222907 -----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java Line 351 (original), 392 (patched) <https://reviews.apache.org/r/73310/#comment312078> duuplicate lines 392/394 and 400/402: consider replacing: ``` String attrValuePrefix = replaceWildCard ? ":*" : ":"; queryBuilder.append("+").append(indexFieldName).append(attrValuePrefix).append(attributeValue).append(" "); ``` - Sarath Subramanian On April 29, 2021, 3:46 a.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73310/ > ----------------------------------------------------------- > > (Updated April 29, 2021, 3:46 a.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-4267 > https://issues.apache.org/jira/browse/ATLAS-4267 > > > Repository: atlas > > > Description > ------- > > Quick search with attribute filter : > > qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1." has > empty AggregationMetrics > > whereas with "default.datagen_table_sensitive_725_1" has right > AggregationMetrics. __ > > > Diffs > ----- > > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java > 1dd8be7e9 > > graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilderTest.java > c2acc5b34 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 3750799f7 > > repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java > f55577c8c > > > Diff: https://reviews.apache.org/r/73310/diff/2/ > > > Testing > ------- > > Unit test case added > Precommit : > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/529/console > > > Thanks, > > Pinal Shah > >
