----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73314/#review222915 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On April 29, 2021, 7:39 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73314/ > ----------------------------------------------------------- > > (Updated April 29, 2021, 7:39 p.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, > Radhika Kundam, and Sidharth Mishra. > > > Bugs: ATLAS-4268 > https://issues.apache.org/jira/browse/ATLAS-4268 > > > Repository: atlas > > > Description > ------- > > Issue: > Enabled deferred actions > > Create term term1. > > Add tag tag1 to term1. > > Associate term1 to entity1 > > Expected that tag1 will be propagated to entity1 from term1 , but didn't > happen. > > Associated a new tag tag2 to term1 , now that tag2 is associated to entity1 > > > Solution: > > Previously during deferred action only impacted vertices were computed, this > should be updated to comput included impacted vertices to handle source > entity as well. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 2a71e345b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 2e0f39a73 > > > Diff: https://reviews.apache.org/r/73314/diff/1/ > > > Testing > ------- > > Precommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/531/console > > Manually verified: > > 1. Created new term 'myterm' under glossary 'MyGlossary' and assigned > classification PII (propagation=true) > 2. assigned term myterm to an entity with lineage > 3. verified classification is propagated to source entity to which term is > assigned and also to all downstream entities. > > > Also validated use case to create a new table from existing table (having > term with classification assigned), verified that classification propagated. > > > Thanks, > > Sarath Subramanian > >
