> On April 29, 2021, 6:16 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > > Lines 602 (patched) > > <https://reviews.apache.org/r/73316/diff/1/?file=2249611#file2249611line602> > > > > listContainsVertex -> findByVertexId, pass vertexId as parameter, that > > will address earlier comment.
updated to use map - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73316/#review222917 ----------------------------------------------------------- On April 29, 2021, 9:01 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73316/ > ----------------------------------------------------------- > > (Updated April 29, 2021, 9:01 p.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, > Radhika Kundam, and Sidharth Mishra. > > > Bugs: ATLAS-4269 > https://issues.apache.org/jira/browse/ATLAS-4269 > > > Repository: atlas > > > Description > ------- > > Issue > ===== > 1.Create a lineage as attached in the screenshot (see JIRA) tag propagated > from a source using 2 processes to a target > > 2. Add a tag to t3 , now the tag is propagated to t4 via both process1 and > process2. > > 3. Now block the propagation from t3 to process1. > > 4. Expectation is that , tag will be propagated via process2 to t4. But the > propagated tag is removed from t4 > > > Solution: > ========= > > Recently tag propagation logic was updated to use queue implementation. When > adding impacted vertices to the result added a check to see if vertex already > present. So no duplicates present. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 9abcf646c > > > Diff: https://reviews.apache.org/r/73316/diff/2/ > > > Testing > ------- > > Precommit: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console > > Manually validated in circular lineage > > > Thanks, > > Sarath Subramanian > >
