-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73358/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and
Sarath Subramanian.
Bugs: ATLAS-4288
https://issues.apache.org/jira/browse/ATLAS-4288
Repository: atlas
Description
-------
ATLAS-4288: Added code to create PreferredToTerms relationships when it exists
alone
Diffs
-----
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
ee306c6b0
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
fa02c8eb9
Diff: https://reviews.apache.org/r/73358/diff/1/
Testing
-------
Manually tested. Changed code to take care of preferredToTerms relation when it
exists without any other relations. Below it has also self-reference so now its
throwing error for self reference and then creating the remaining relations
successfully. Check below error messages and response json.
Response json:
{
"failedImportInfoList": [
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_1",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_2",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_3",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_4",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_5",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_8",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_9",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_10",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_11",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_12",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
,
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_13",
"importStatus": "FAILED", "remarks": "Invalid Term relationship: Term cant have
a relationship with self" }
],
"successImportInfoList": [
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_1",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"a83cf35d-22f5-4b4c-8d4f-1d658c85b0ae\",\"qualifiedName\":\"term_1@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_2",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"77d08bd2-9cff-489e-9240-50f2c0f68d89\",\"qualifiedName\":\"term_2@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_3",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"10563ed5-c1fb-438e-bead-b6f0ccbd4d44\",\"qualifiedName\":\"term_3@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_4",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"0f1ec608-4692-4041-b7d4-e270032f2bac\",\"qualifiedName\":\"term_4@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_5",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"30728c5b-99f6-4f69-a54a-2b0d4d49acef\",\"qualifiedName\":\"term_5@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_6",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"b075398a-f845-42ca-90b0-e1362c5757c4\",\"qualifiedName\":\"term_6@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_7",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"0c75f006-9d29-49db-96bb-b9c7738eb155\",\"qualifiedName\":\"term_7@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_8",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"e3cee557-1017-44ed-bfd1-fa42bf9f2b51\",\"qualifiedName\":\"term_8@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_9",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"63635428-a966-4843-b8c8-97576fa349da\",\"qualifiedName\":\"term_9@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_10",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"44cbaf67-9d66-42ad-b339-c97804b5980d\",\"qualifiedName\":\"term_10@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_11",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"df8216f9-bbdb-4264-91f2-b3ed50870a15\",\"qualifiedName\":\"term_11@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_12",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"9275a2e1-ff61-4276-bee2-882c133404bd\",\"qualifiedName\":\"term_12@dharshmk_11\"}
"
},
{ "parentObjectName": "dharshmk_11", "childObjectName": "term_13",
"importStatus": "SUCCESS", "remarks":
"{\"termGuid\":\"c76091e9-db22-40e4-8c7b-8fc52e08706f\",\"qualifiedName\":\"term_13@dharshmk_11\"}
"
}
]
}
Thanks,
Sidharth Mishra
