----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73372/#review223037 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java Line 996 (original), 996 (patched) <https://reviews.apache.org/r/73372/#comment312198> Extract method: getGlossaryTemplateAsAttachment. webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java Line 1001 (original), 1001 (patched) <https://reviews.apache.org/r/73372/#comment312197> Refactor: Extract to const field. That way file name is at one place. - Ashutosh Mestry On May 24, 2021, 6:54 p.m., Umesh Padashetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73372/ > ----------------------------------------------------------- > > (Updated May 24, 2021, 6:54 p.m.) > > > Review request for atlas, Ashutosh Chauhan and Sarath Subramanian. > > > Bugs: ATLAS-4305 > https://issues.apache.org/jira/browse/ATLAS-4305 > > > Repository: atlas > > > Description > ------- > > Atlas provides support to Bulk Import Business Metadata and Glossary. THe > user can download the template file and then bulk upload the data to atlas. > > > While the Business Metadata template file is named as > "template_business_metadata", Glossary Bulk Import template file is just > named as "template". This leads to confusion when the user downloads both the > template files and he/she has to open the file to confirm the template type > > > Proposal: Rename the template file to template_glossary > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java c1de83be9 > > > Diff: https://reviews.apache.org/r/73372/diff/1/ > > > Testing > ------- > > > Thanks, > > Umesh Padashetty > >
