----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73376/#review223044 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java Lines 47 (patched) <https://reviews.apache.org/r/73376/#comment312201> Rename: entitiesUniqAttributes -> entityUniqAttributes - Ashutosh Mestry On May 26, 2021, 12:19 a.m., Sidharth Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73376/ > ----------------------------------------------------------- > > (Updated May 26, 2021, 12:19 a.m.) > > > Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and > Sarath Subramanian. > > > Bugs: ATLAS-4307 > https://issues.apache.org/jira/browse/ATLAS-4307 > > > Repository: atlas > > > Description > ------- > > ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate > classification to bulk entities with uniq attribute and type > > > Diffs > ----- > > > intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java > 3f946ef7a > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ec893f25c > > > Diff: https://reviews.apache.org/r/73376/diff/1/ > > > Testing > ------- > > Manually tested. With new changes the three options will be: > > Option 1 (Only with type name and list of uniq attributes) > > curl --location --request POST > 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True' > \ > --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \ > --header 'Content-Type: application/json' \ > --data-raw '{ > "classification" : { > "propagate" : false, > "attributes" : { > "type" : "false" > }, > "typeName" : "TEST_TAG_TABLE" > }, > "entitiesUniqAttributes" : [ > {"qualifiedName": "db1.table43@cm"}, > {"qualifiedName": "db1.table7@cm"}, > {"qualifiedName": "db1.table55@cm"}], > "entityTypeName" : "hive_table" > }' > > Option 2 (Only with entity Guids) > curl --location --request POST > 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True' > \ > --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \ > --header 'Content-Type: application/json' \ > --data-raw '{ > "classification" : { > "propagate" : false, > "attributes" : { > "type" : "false" > }, > "typeName" : "TEST_TAG_TABLE" > }, > "entityGuids" : ["f7288e81-46e4-4c88-b6c7-da092d6b6e35", > "1793c6df-53a6-481b-a75c-c705f98d6900"], > "entityTypeName" : "hive_table" > }' > > Option 3 (With both entity GUIDs and type Name with list of uniq attributes) > curl --location --request POST > 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True' > \ > --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \ > --header 'Content-Type: application/json' \ > --data-raw '{ > "classification" : { > "propagate" : false, > "attributes" : { > "type" : "false" > }, > "typeName" : "TEST_TAG_TABLE" > }, > "entitiesUniqAttributes" : [ > {"qualifiedName": "db1.table43@cm"}, > {"qualifiedName": "db1.table8@cm"}, > {"qualifiedName": "db1.table55@cm"}], > "entityGuids" : [ > "6d6ab082-9a62-4aea-97b7-2b7337173631", > "9a0d3275-eb42-4229-ac51-6db1ddf3ccc6"], > "entityTypeName" : "hive_table" > }' > > > Thanks, > > Sidharth Mishra > >