----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73404/#review223103 -----------------------------------------------------------
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java Lines 62 (patched) <https://reviews.apache.org/r/73404/#comment312234> If config property is set, user should be mindful of including all the 6 path types as well, else shell entities will be created. The types specified from config should only append to the default types. Without defaultTypes all path lineage will be broken. addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java Lines 182 (patched) <https://reviews.apache.org/r/73404/#comment312235> we may not need separate instanceof check for AtlasRelatedObjectId. Lines 188-192 should suffice, since guid belongs to parent - AtlasObjectId. Consider removing 182-187 addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java Line 201 (original), 191 (patched) <https://reviews.apache.org/r/73404/#comment312236> This will also set all path entity types guid to null. If guid is null (non-negative guid is not specified). IdBasedResolver will be ignored and UniqueAttributeBasedResolver will not be able to fetch the entity and result in shell entity creation. The earlier check to ignore path entity types would avoid this. Please review. - Sarath Subramanian On June 3, 2021, 2:52 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73404/ > ----------------------------------------------------------- > > (Updated June 3, 2021, 2:52 p.m.) > > > Review request for atlas, Mandar Ambawane, Radhika Kundam, and Sarath > Subramanian. > > > Bugs: ATLAS-4324 > https://issues.apache.org/jira/browse/ATLAS-4324 > > > Repository: atlas > > > Description > ------- > > **Approach** > Updates: > - Simplified approach. > - Maintained abstraction. > - Updated unit tests. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java > 737c637bf > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java > 9163c4709 > > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java > 4dde1dc2f > > addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain-v2.json > 42553b5cf > > addons/hive-bridge/src/test/resources/json/hs2-create-db-with-no-pathentities-to-retain.json > a5b810f72 > addons/hive-bridge/src/test/resources/json/hs2-load-inpath-v2.json > dd31aa073 > > addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain-v2.json > 7f90d1986 > > addons/hive-bridge/src/test/resources/json/hs2-load-inpath-with-no-pathentities-to-retain.json > dd31aa073 > addons/hive-bridge/src/test/resources/json/hs2-load-inpath.json dd31aa073 > > > Diff: https://reviews.apache.org/r/73404/diff/1/ > > > Testing > ------- > > **Unit tests** > - Additional unit test. > > > Thanks, > > Ashutosh Mestry > >
