----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73412/#review223125 -----------------------------------------------------------
Can you please add unit test in GremlinQueryComposerTest. repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java Lines 137 (patched) <https://reviews.apache.org/r/73412/#comment312249> A static private final Set<Character> can be used here, instead. - Ashutosh Mestry On June 9, 2021, 2:47 p.m., Pinal Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73412/ > ----------------------------------------------------------- > > (Updated June 9, 2021, 2:47 p.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4332 > https://issues.apache.org/jira/browse/ATLAS-4332 > > > Repository: atlas > > > Description > ------- > > **Problem:** In DSL query , searching with like operator in combination of > special characters like '/' in search text throws 500 > > **Example:** > hdfs_path name="/warehouse/tablespace/external/hive/db_fdchj.db" returns > right entity. > > hdfs_path name like "/warehouse/*" throws following exception: > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > 320acbe22 > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > c53a324a1 > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 99e075ac5 > repository/src/test/java/org/apache/atlas/query/BaseDSLComposer.java > b10400157 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 0c1dd59d2 > > > Diff: https://reviews.apache.org/r/73412/diff/1/ > > > Testing > ------- > > unit testcase added > > Precommit : > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/640/console > (In Progress) > > > Thanks, > > Pinal Shah > >
